qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: add more detailed hint of old libfdt


From: john.liuli
Subject: Re: [Qemu-devel] [PATCH] configure: add more detailed hint of old libfdt-dev missing libfdt_env.h
Date: Tue, 22 Apr 2014 19:52:30 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0



On 2014/4/22 17:38, john.liuli wrote:
"john.liuli" <address@hidden> writes:

libfdt_env.h is missing in some stable installs (<1.3.0-3), some
released linux distributions(e.g. Ubuntu 12.04) depending on it still
complain missing libfdt even if already installed.
So give more detailed hint for such OS users.

Signed-off-by: Liu Li <address@hidden>
---
 configure |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 69b9f56..6fe80e0 100755
--- a/configure
+++ b/configure
@@ -2949,7 +2949,9 @@ EOF
   elif test "$fdt" = "yes" ; then
     # have neither and want - prompt for system/submodule install
     error_exit "DTC (libfdt) not present. Your options:" \
-        "  (1) Preferred: Install the DTC (libfdt) devel package" \
+        "  (1) Preferred: Install the DTC (libfdt) devel package," \
+        "      old version(<1.3.0-3) lost libfdt_env.h, so need" \

"lost"?  Do you mean "lacks"?

Ah, I mean "lacks".


+        "      to be fixed manually after installation" \
         "  (2) Fetch the DTC submodule, using:" \
         "      git submodule update --init dtc"
   else

If your libfdt-devel package lacks a required header, my advice would be
to use the DTC submodule, not to "fix manually" (whatever that means).


Yeah, DTC submodule is a good choice, but the prefix "Preferred" imply that 1st is more better for me. So can we reorder these two choices?

DTC submodule's URL defined in .gitmodules as git://git.qemu-project.org/dtc.git. Sometime git protocol is blocked for unknown(security etc.) reasons. http://git.qemu.org/git/dtc.git may be a more common choice.(just personally suggestion ;))





reply via email to

[Prev in Thread] Current Thread [Next in Thread]