Re: [Qemu-devel] [PATCH] configure: add more detailed hint of old libfdt-dev missing libfdt_env.h

[john.liuli]

On 2014/4/22 19:56, john.liuli wrote:
> On 21 April 2014 07:18, john.liuli <address@hidden> wrote:
> > libfdt_env.h is missing in some stable installs (<1.3.0-3), some
> > released linux distributions(e.g. Ubuntu 12.04) depending on it still
> > complain missing libfdt even if already installed.
> > So give more detailed hint for such OS users.
> >
> > Signed-off-by: Liu Li <address@hidden>
> > ---
> >  configure |    4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 69b9f56..6fe80e0 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2949,7 +2949,9 @@ EOF
> >    elif test "$fdt" = "yes" ; then
> >      # have neither and want - prompt for system/submodule install
> >      error_exit "DTC (libfdt) not present. Your options:" \
> > -        "  (1) Preferred: Install the DTC (libfdt) devel package" \
> > +        "  (1) Preferred: Install the DTC (libfdt) devel package," \
> > +        "      old version(<1.3.0-3) lost libfdt_env.h, so need" \
> > +        "      to be fixed manually after installation" \
>
> 1.3.0-3 is an Ubuntu version, not an upstream one, isn't it?
>
> We could just update the first line to say "libfdt not present or too old".
> I agree with Markus that we should definitely not be suggesting that
> users manually mess with trying to fix up their distro's package.

Yeah, we shouldn't. "libfdt not present or too old" is a more good hint. 
But at the same time the second line may be updated as "Preferred: 
Install or update the DTC (libfdt) devel package".

> >          "  (2) Fetch the DTC submodule, using:" \
> >          "      git submodule update --init dtc"
> >    else
>
> thanks
> -- PMM
>
>
> .