Re: [Qemu-devel] [PATCH v5 11/12] iotests: Add test for backing-chain commits

[Eric Blake]

On 04/17/2014 03:59 PM, Max Reitz wrote:
> Add a test for qemu-img commit on backing chains with more than two
> images. This test also checks whether the images above the base image
> are emptied and does therefore not work for qed and vmdk which requires
> it to be separate from 020.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  tests/qemu-iotests/089     | 103 
> +++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/089.out |  56 ++++++++++++++++++++++++
>  tests/qemu-iotests/group   |   1 +
>  3 files changed, 160 insertions(+)
>  create mode 100755 tests/qemu-iotests/089
>  create mode 100644 tests/qemu-iotests/089.out
> 

> +# Three passes:
> +#  0: Two-layer backing chain, commit to upper backing file (default)
> +#  1: Two-layer backing chain, commit to lower backing file
> +#
> +# 020 already tests committing, so this only tests whether image chains are
> +# working properly and that all images above the base are emptied; therefore,
> +# no complicated patterns are necessary
> +for i in 0 1; do

"Three passes" sounds like a stale comment.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature