[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 01/02] seccomp: add timerfd_create and timerfd_se
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PULL 01/02] seccomp: add timerfd_create and timerfd_settime to the whitelist |
|
Date: |
Tue, 22 Apr 2014 18:17:33 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 22.04.2014 15:56, schrieb Eduardo Otubo:
>
>
> On 04/14/2014 03:00 PM, Eduardo Otubo wrote:
>> Signed-off-by: Felix Geyer <address@hidden>
>> Signed-off-by: Eduardo Otubo <address@hidden>
>
> Sorry, Peter, you mean this one?
> Should I remove Acked-by? I had other patches with Acked-by merged with
> no problems before.
Apart from the issue of the Git tree [1] diverging from the patches,
your Signed-off-by should be last. There's nothing particularly wrong
with Acked-by otherwise, except that it's not adding any information
over Signed-off-by, and when used last may cause confusion.
Cheers,
Andreas
[1] https://github.com/otubo/qemu/commits/seccomp
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg