Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: improve "info registers" by printing SPRs

[Scott Wood]

On Thu, 2014-03-20 at 01:17 +1100, Alexey Kardashevskiy wrote:
> This adds printing of all SPR registers registered for a CPU.
> 
> This removes "SPR_" prefix from SPR name to reduce the output.
> 
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> ---
> 
> 
> Now it should look like below. Before the user had to attach with gdb
> to read SPRs.

Can't you use "p $sprname" as suggested by the code comment about IVORs?
If all SPRs, including IVORs, are printed, then the booke output is
going to get quite large.

> (qemu) info registers 
> NIP 0000000000000100   LR 0000000000000000 CTR 0000000000000000 XER 
> 0000000000000000
> MSR 0000000000000000 HID0 0000000000000000  HF 0000000000000000 idx 1
> TB 00000000 00000000 DECR 00000000
> GPR00 0000000000000000 0000000000000000 0000000000000000 000000000ffb0000
> GPR04 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> GPR08 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> GPR12 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> GPR16 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> GPR20 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> GPR24 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> GPR28 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> CR 00000000  [ -  -  -  -  -  -  -  -  ]             RES ffffffffffffffff
> FPR00 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> FPR04 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> FPR08 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> FPR12 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> FPR16 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> FPR20 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> FPR24 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> FPR28 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> FPSCR 0000000000000000
> XER    0000000000000000 LR     0000000000000000 CTR    0000000000000000 UAMR  
>  0000000000000000
> DSCR   0000000000000000 DSISR  0000000000000000 DAR    0000000000000000 DECR  
>  0000000000000000
> SDR1   0000000000000005 SRR0   0000000000000000 SRR1   0000000000000000 CFAR  
>  0000000000000000
> AMR    0000000000000000 CTRLF  0000000080800000 CTRLT  0000000080800000 UAMOR 
>  0000000000000000
> VRSAVE 0000000000000000 TBL    0000000000000000 TBU    0000000000000000 SPRG0 
>  0000000000000000
> SPRG1  0000000000000000 SPRG2  0000000000000000 SPRG3  0000000000000000 EAR   
>  0000000000000000
> TBL    0000000000000000 TBU    0000000000000000 PVR    00000000003f0201 SPURR 
>  0000000000000000
> PURR   0000000000000000 LPCR   0000000000007005 MMCRA  0000000000000000 PPR   
>  0000000000000000
> UMMCR0 0000000000000000 UPMC1  0000000000000000 UPMC2  0000000000000000 USIAR 
>  0000000000000000
> UMMCR1 0000000000000000 UPMC3  0000000000000000 UPMC4  0000000000000000 PMC5  
>  0000000000000000
> PMC6   0000000000000000 MMCR0  0000000000000000 PMC1   0000000000000000 PMC2  
>  0000000000000000
> SIAR   0000000000000000 MMCR1  0000000000000000 PMC3   0000000000000000 PMC4  
>  0000000000000000
> IABR   0000000000000000 DABR   0000000000000000 ICTC   0000000000000000 PIR   
>  0000000000000000

If this approach is accepted, could we at least keep the output within
80 columns?

-Scott