Re: [Qemu-devel] [patch 1/2] target-i386: support "invariant tsc" flag

[Eduardo Habkost]

On Tue, Apr 22, 2014 at 08:26:36PM -0400, Paolo Bonzini wrote:
> Il 22/04/2014 15:10, Marcelo Tosatti ha scritto:
> >+    case 0x80000007:
> >+        *eax = 0;
> >+        *ebx = 0;
> >+        *ecx = 0;
> >+
> >+        if (kvm_enabled()) {
> >+            *edx = env->features[FEAT_8000_0007_EDX];
> >+        } else {
> >+            *edx = 0;
> >+        }
> 
> I think TCG is able to eliminate unsupported features too before they
> get in env->features[].  Or are those patches not in yet?  Eduardo?

They are not in yet, but while they are not included this filtering
(based on TCG_*_FEATURES macros) should be done in the !kvm_enabled()
block of x86_cpu_realizefn().

-- 
Eduardo