qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/10] qtest: Be paranoid about accept() addrlen


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 05/10] qtest: Be paranoid about accept() addrlen argument
Date: Thu, 24 Apr 2014 06:55:02 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

On 04/24/2014 06:49 AM, Andreas Färber wrote:
> POSIX specifies that address_len shall on output specify the length of
> the stored address; it does not however specify whether it may get
> updated on failure as well to, e.g., zero.

Your reading of POSIX leaving the value undefined matches mine.  It may
indeed be worth a report to the POSIX folks to see if that should be
tightened in the future to guarantee that it is unchanged on failure,
but we can't rely on that now.

> 
> In case EINTR occurs, re-initialize the variable to the desired value.
> 
> Cc: Eric Blake <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
>  tests/libqtest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]