[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/10] qtest: Be paranoid about accept() addrlen arg
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PATCH 05/10] qtest: Be paranoid about accept() addrlen argument |
Date: |
Thu, 24 Apr 2014 14:49:18 +0200 |
POSIX specifies that address_len shall on output specify the length of
the stored address; it does not however specify whether it may get
updated on failure as well to, e.g., zero.
In case EINTR occurs, re-initialize the variable to the desired value.
Cc: Eric Blake <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
tests/libqtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 4b90d91..71468ac 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -89,8 +89,8 @@ static int socket_accept(int sock)
setsockopt(sock, SOL_SOCKET, SO_RCVTIMEO, (void *)&timeout,
sizeof(timeout));
- addrlen = sizeof(addr);
do {
+ addrlen = sizeof(addr);
ret = accept(sock, (struct sockaddr *)&addr, &addrlen);
} while (ret == -1 && errno == EINTR);
if (ret == -1) {
--
1.8.4.5
- [Qemu-devel] [PATCH 09/10] tests: Add ioh3420 qtest, (continued)
- [Qemu-devel] [PATCH 09/10] tests: Add ioh3420 qtest, Andreas Färber, 2014/04/24
- [Qemu-devel] [PATCH 04/10] qtest: Add error reporting to socket_accept(), Andreas Färber, 2014/04/24
- [Qemu-devel] [PATCH 08/10] tests: Add intel-hda qtests, Andreas Färber, 2014/04/24
- [Qemu-devel] [PATCH 10/10] tests: Add EHCI qtest, Andreas Färber, 2014/04/24
- [Qemu-devel] [PATCH 07/10] tests: Add es1370 qtest, Andreas Färber, 2014/04/24
- [Qemu-devel] [PATCH 03/10] qtest: Assure that init_socket()'s listen() does not fail, Andreas Färber, 2014/04/24
- [Qemu-devel] [PATCH 02/10] MAINTAINERS: Document I2C libqos, Andreas Färber, 2014/04/25
- [Qemu-devel] [PATCH 06/10] tests: Add ac97 qtest, Andreas Färber, 2014/04/25
- [Qemu-devel] [PATCH 05/10] qtest: Be paranoid about accept() addrlen argument,
Andreas Färber <=
- [Qemu-devel] [PATCH 01/10] MAINTAINERS: Take maintainership for QTest, Andreas Färber, 2014/04/25
- Re: [Qemu-devel] [PATCH 01/10] MAINTAINERS: Take maintainership for QTest, Paolo Bonzini, 2014/04/28