qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.1 v1 2/3] qdev: Implement named GPIOs


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH for-2.1 v1 2/3] qdev: Implement named GPIOs
Date: Thu, 24 Apr 2014 16:02:57 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

Am 09.04.2014 01:45, schrieb Peter Crosthwaite:
> Implement named GPIOs on the Device layer. Listifies the existing GPIOs
> stuff using string keys. Legacy un-named GPIOs are preserved by using
> a NULL name string - they are just a single matchable element in the
> name list.
> 
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> 
>  hw/core/qdev.c         | 82 
> ++++++++++++++++++++++++++++++++++++++++++--------
>  include/hw/qdev-core.h | 25 ++++++++++++---
>  qdev-monitor.c         | 14 ++++++---
>  qtest.c                | 15 ++++++---
>  4 files changed, 110 insertions(+), 26 deletions(-)

Please don't roll your own list implementation, use qemu/queue.h.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]