Re: [Qemu-devel] [PATCH] configure: Change --enable-tpm to --disable-tpm

[Cole Robinson]

On 04/21/2014 10:16 PM, Fam Zheng wrote:
> On Mon, 04/21 19:09, Cole Robinson wrote:
>> I don't see why tpm is disabled by default: it doesn't have any
>> external dependencies, or change default behavior. Leaving it disabled
>> is just going to cause it to bit rot.
>>
>> Enable it by default, and change --enable-tpm to --disable-tpm if
>> people still want an option to compile it out.
>>
>> Signed-off-by: Cole Robinson <address@hidden>
>> ---
>>  configure | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 69b9f56..45dc100 100755
>> --- a/configure
>> +++ b/configure
>> @@ -320,7 +320,7 @@ virtio_blk_data_plane=""
>>  gtk=""
>>  gtkabi="2.0"
>>  vte=""
>> -tpm="no"
>> +tpm="yes"
>>  libssh2=""
>>  vhdx=""
>>  quorum="no"
>> @@ -1073,7 +1073,7 @@ for opt do
>>    ;;
>>    --enable-vte) vte="yes"
>>    ;;
>> -  --enable-tpm) tpm="yes"
>> +  --disable-tpm) tpm="no"
>>    ;;
>>    --disable-libssh2) libssh2="no"
>>    ;;
>> @@ -1343,7 +1343,7 @@ Advanced options (experts only):
>>    --disable-glusterfs      disable GlusterFS backend
>>    --enable-gcov            enable test coverage analysis with gcov
>>    --gcov=GCOV              use specified gcov [$gcov_tool]
>> -  --enable-tpm             enable TPM support
>> +  --disable-tpm            disable TPM support
>>    --disable-libssh2        disable ssh block device support
>>    --enable-libssh2         enable ssh block device support
>>    --disable-vhdx           disables support for the Microsoft VHDX image 
>> format
> 
> Enabling it by default sounds fine, but removing the configure option may 
> break
> existing building scripts. Why not just add "--disable-tpm"?
> 

Will send a fixed patch shortly.

Thanks,
Cole