Re: [Qemu-devel] [PATCH] monitor: fix qmp_getfd() fd leak in error case

[Luiz Capitulino]

On Thu, 24 Apr 2014 13:58:18 +0200
Stefan Hajnoczi <address@hidden> wrote:

> qemu_chr_fe_get_msgfd() transfers ownership of the file descriptor to
> the caller.  Therefore all code paths in qmp_getfd() should either
> register the file descriptor somewhere or close it.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>

Applied to the qmp branch, thanks.

> ---
>  monitor.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/monitor.c b/monitor.c
> index 342e83b..7506ff5 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2254,6 +2254,7 @@ void qmp_getfd(const char *fdname, Error **errp)
>      }
>  
>      if (qemu_isdigit(fdname[0])) {
> +        close(fd);
>          error_set(errp, QERR_INVALID_PARAMETER_VALUE, "fdname",
>                    "a name not starting with a digit");
>          return;