[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/5] block: Purge error_is_set()
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/5] block: Purge error_is_set() |
Date: |
Fri, 25 Apr 2014 18:05:50 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Apr 25, 2014 at 04:50:30PM +0200, Markus Armbruster wrote:
> I got a private branch getting rid of it entirely. This is the first
> part, covering the block subsystem.
>
> v2:
> * Rebased, trivial semantic conflict in 1/5 resolved
> * Use local_err rather than err in 2/5 [Kevin]
>
> Markus Armbruster (5):
> Use error_is_set() only when necessary (again)
> qemu-img: Consistently name Error * objects err, and not errp
> nbd: Use return values instead of error_is_set(errp)
> blockdev: Clean up fragile use of error_is_set()
> iscsi: Don't use error_is_set() to suppress additional errors
>
> block.c | 2 +-
> block/iscsi.c | 9 ++++-----
> block/mirror.c | 2 +-
> block/nbd.c | 2 +-
> block/nfs.c | 2 +-
> block/quorum.c | 4 ++--
> blockdev.c | 7 +++++--
> docs/writing-qmp-commands.txt | 6 +++---
> qemu-img.c | 12 ++++++------
> tests/test-qmp-input-strict.c | 8 ++++----
> 10 files changed, 28 insertions(+), 26 deletions(-)
>
> --
> 1.8.1.4
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
- [Qemu-devel] [PATCH v2 0/5] block: Purge error_is_set(), Markus Armbruster, 2014/04/25
- [Qemu-devel] [PATCH v2 2/5] qemu-img: Consistently name Error * objects err, and not errp, Markus Armbruster, 2014/04/25
- [Qemu-devel] [PATCH v2 3/5] nbd: Use return values instead of error_is_set(errp), Markus Armbruster, 2014/04/25
- [Qemu-devel] [PATCH v2 1/5] Use error_is_set() only when necessary (again), Markus Armbruster, 2014/04/25
- [Qemu-devel] [PATCH v2 5/5] iscsi: Don't use error_is_set() to suppress additional errors, Markus Armbruster, 2014/04/25
- [Qemu-devel] [PATCH v2 4/5] blockdev: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/04/25
- Re: [Qemu-devel] [PATCH v2 0/5] block: Purge error_is_set(),
Stefan Hajnoczi <=