[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/16] vnc: Remove default_mon usage
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PULL 02/16] vnc: Remove default_mon usage |
Date: |
Fri, 25 Apr 2014 14:29:33 -0400 |
From: Cole Robinson <address@hidden>
These errors don't seem user initiated, so forcibly printing to the
monitor doesn't seem right. Just use error_report.
Cc: Anthony Liguori <address@hidden>
Cc: Gerd Hoffmann <address@hidden>
Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>
---
ui/vnc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 5925774..2d7def9 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -996,7 +996,7 @@ static void audio_add(VncState *vs)
struct audio_capture_ops ops;
if (vs->audio_cap) {
- monitor_printf(default_mon, "audio already running\n");
+ error_report("audio already running");
return;
}
@@ -1006,7 +1006,7 @@ static void audio_add(VncState *vs)
vs->audio_cap = AUD_add_capture(&vs->as, &ops, vs);
if (!vs->audio_cap) {
- monitor_printf(default_mon, "Failed to add audio capture\n");
+ error_report("Failed to add audio capture");
}
}
--
1.9.0
- [Qemu-devel] [PULL 14/16] HMP: fix doc of dump-guest-memory, (continued)
- [Qemu-devel] [PULL 14/16] HMP: fix doc of dump-guest-memory, Luiz Capitulino, 2014/04/25
- [Qemu-devel] [PULL 06/16] qerror.h: Remove unused error classes, Luiz Capitulino, 2014/04/25
- [Qemu-devel] [PULL 07/16] qerror.h: Remove QERR defines that are only used once, Luiz Capitulino, 2014/04/25
- [Qemu-devel] [PULL 15/16] HMP: support specifying dump format for dump-guest-memory, Luiz Capitulino, 2014/04/25
- [Qemu-devel] [PULL 16/16] monitor: fix qmp_getfd() fd leak in error case, Luiz Capitulino, 2014/04/25
- [Qemu-devel] [PULL 13/16] qmp: object-add: Validate class before creating object, Luiz Capitulino, 2014/04/25
- [Qemu-devel] [PULL 08/16] qerror.h: Replace QERR_NOT_SUPPORTED with QERR_UNSUPPORTED, Luiz Capitulino, 2014/04/25
- [Qemu-devel] [PULL 09/16] error: Remove some unused headers, Luiz Capitulino, 2014/04/25
- [Qemu-devel] [PULL 12/16] monitor: Add device_add and device_del completion., Luiz Capitulino, 2014/04/25
- [Qemu-devel] [PULL 11/16] monitor: Add command_completion callback to mon_cmd_t., Luiz Capitulino, 2014/04/25
- [Qemu-devel] [PULL 02/16] vnc: Remove default_mon usage,
Luiz Capitulino <=
- [Qemu-devel] [PULL 10/16] monitor: Fix drive_del id argument type completion., Luiz Capitulino, 2014/04/25
- Re: [Qemu-devel] [PULL 00/16] QMP queue, Peter Maydell, 2014/04/28