[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file |
Date: |
Sun, 27 Apr 2014 11:05:55 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/21/2014 12:09 PM, Michael Tokarev wrote:
> 21.04.2014 13:01, Michael Tokarev wrote:
>> libtool has an argument for .syms file, which is -export-symbols.
>> There's no argument `-export-syms', and it looks like at least on
>> linux, -export-syms is just ignored. Use the correct argument,
>> -export-symbols, to actually get the right export list.
>
> Note: with this patch applied, linking vscclient fails due to the
> following symbols missing:
>
> qemu_mutex_lock
> qemu_mutex_unlock
> qemu_cond_wait
> qemu_cond_signal
> qemu_thread_create
> socket_init
> qemu_socket
> qemu_mutex_init
> qemu_cond_init
>
> So it looks like a preparation patch is needed before this one, to
> ensure bisectability.
>
> Should those symbols be exported by libcacard (hence listed in the
> .syms file), or should vscclient link line use more objects?
They should not be exported by libcacard. I'm not sure what is happening
here except to note that the list of objects being linked must satisfy
all missing symbols since it results in a loadable and executable
executable.
>
> Thanks,
>
> /mjt
>
>> Signed-off-by: Michael Tokarev <address@hidden>
>> ---
>> libcacard/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libcacard/Makefile b/libcacard/Makefile
>> index 6b06448..ca08991 100644
>> --- a/libcacard/Makefile
>> +++ b/libcacard/Makefile
>> @@ -24,7 +24,7 @@ vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
>> # Rules for building libcacard standalone library
>>
>> libcacard.la: LDFLAGS += -rpath $(libdir) -no-undefined \
>> - -export-syms $(SRC_PATH)/libcacard/libcacard.syms
>> + -export-symbols $(SRC_PATH)/libcacard/libcacard.syms
>> libcacard.la: LIBS = $(libcacard_libs)
>> libcacard.la: $(libcacard-lobj-y)
>> $(call LINK,$^)
>>
>
- [Qemu-devel] [PATCH] libcacard: actually use the symbols file, Michael Tokarev, 2014/04/21
- Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file, Michael Tokarev, 2014/04/21
- Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file,
Alon Levy <=
- Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file, Michael Tokarev, 2014/04/27
- Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file, Paolo Bonzini, 2014/04/27
- Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file, Michael Tokarev, 2014/04/27
- Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file, Paolo Bonzini, 2014/04/27
- Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file, Michael Tokarev, 2014/04/27
- Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file, Paolo Bonzini, 2014/04/27
- Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file, Michael Tokarev, 2014/04/27