Re: [Qemu-devel] [PATCH] libcacard: actually use symbols file

[Michael Tokarev]

27.04.2014 18:53, Alon Levy wrote:
> On 04/27/2014 05:37 PM, Michael Tokarev wrote:
>> libtool has an argument for .syms file, which is -export-symbols.
>> There's no argument `-export-syms', and it looks like at least on
>> linux, -export-syms is just ignored.  Use the correct argument,
>> -export-symbols, to actually get the right export list.
>>
>> But it turns out that vscclient binary, which also uses qemu
>> privitives for sockets, mutexes and some other stuff, but only
>> linked with libcacard, does not link after hiding extra symbols
>> previously exported by libcacard.  So while at it, link it with
>> libqemuutil.a and libqemustub.a.  This makes the binary as twice
>> as large, but allows to have cleaner export table for libcacard.so.
>>
> 
> Reviewed-by: Alon Levy <address@hidden>
> 
> Any chance to get this through the trivial patch queue?

Well sure.  Except that un-exporting internal symbols like this from
libcacard.so might have non-trivial consequences, like we've seen with
vscclient ;)

I've added it to the trivial-patches queue for now.

Thanks!

/mjt