qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v25 31/31] QemuOpts: cleanup tmp 'allocated' mem


From: Chun Yan Liu
Subject: Re: [Qemu-devel] [PATCH v25 31/31] QemuOpts: cleanup tmp 'allocated' member from QemuOptsList
Date: Mon, 28 Apr 2014 00:22:22 -0600


>>> On 4/25/2014 at 09:43 PM, in message
<address@hidden>, Stefan Hajnoczi
<address@hidden> wrote: 
> On Fri, Apr 11, 2014 at 01:54:27AM +0800, Chunyan Liu wrote: 
> >  /* Realloc dst option list and append options from an option list (list) 
> >   * to it. dst could be NULL or a malloced list. 
> > + * Result dst has shorter lifetime then input list. 
>  
> s/then/than/ 
>  
> But I think it's helpful to be more explicit: 
>  
> The lifetime of dst must be shorter than the input list because the 
> QemuOptDesc->name, ->help, and ->def_value_str strings are shared. 
>  
>  
Will update. Thanks.

Chunyan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]