Re: [Qemu-devel] [PATCH v2] Add remove_boot_device_path() function for hot-unplug device

[Marcel Apfelbaum]

On Mon, 2014-04-28 at 11:22 +0200, Paolo Bonzini wrote:
> Il 22/04/2014 11:21, Marcel Apfelbaum ha scritto:
> > Here is the *real* problem: fw_boot_order list is not queried
> > again on guest reboot, so 'touching' the list has no effect.
> > While your code is correct (as far as I can tell), it seems
> > that his place is after the above problem is solved.
> 
> Doesn't Jun's patch fix a dangling pointer?  If so, that would come 
> first anyway.
It removes pointers from a "dead" list, and it only deals with
some symptom.
Even if you remove the device from the list, the guest still uses
the previous list. The only difference is that you can now
hot-plug/hot-unplug a disk with a boot-order index. 
However, strange things will happen when you reboot the guest,
one of them may be that it actually works :)

It is possible that I got it wrong...
Thanks,
Marcel

> 
> Paolo
>