Re: [Qemu-devel] [PATCH 01/10] MAINTAINERS: Take maintainership for QTest

[Andreas Färber]

Am 28.04.2014 11:02, schrieb Paolo Bonzini:
> Il 24/04/2014 14:49, Andreas Färber ha scritto:
>> Invented by Anthony. Maintenance has been handled by me lately.
>>
>> Note that the tests themselves are intentionally not part of this entry;
>> they are considered part of the device or subsystem they are covering.
>>
>> Cc: Anthony Liguori <address@hidden>
>> Cc: Stefan Hajnoczi <address@hidden>
>> Signed-off-by: Andreas Färber <address@hidden>
> 
> Actually, I see a mix of Stefan, mst, and you.

Maybe I should have better formulated "through my tree lately"? Because
I did handle Stefan's recent patches.

>  I respectfully think
> that qtest is still better served by "community-style" maintainership.

That is exactly where we have been disagreeing over the last few months:
Community-style maintenance does not work. In particular, Anthony used
to handle such patches himself but does not any more. Peter is asking
for pulls, we as community need someone to take decision on how to go
about things (e.g., Stefan vs. Marcel), and you are - with all due
respect - the only longtime contributor sending or asking about sending
pulls for random series of yours one week after patches have been
posted, for code that you refuse to step up as maintainer for (memory,
Makefile infrastructure, tmp105, ...).

Stefan has specifically called for someone to step up [1, 2], and if
that is you or mst or PMM (CC'ed), less work for me! As long as patches
and infrastructure don't bitrot and my test cases keep making progress
(which I am rebasing any QOM changes on, so sending them prepended to
qom-next seems natural) I am fine. None of you volunteered at the time.
Stefan would've been my proposal as the most active, but he declined.

So the issues here are twofold,
a) who sends pulls? Stefan's patches went through me, and no one
bothered to review libqtest.[hc] API changes of mine. Note that this
patch does not fix any tree via T:, so it or a variation thereof could
be applied independently.
b) who gets CC'ed on and reviews patches? Currently neither me nor
Stefan nor mst are CC'ed by get_maintainer.pl. This patch adds me.
Review currently mostly relies on contributors CC'ing undocumented
people who care to review - extending this patch to a bigger pool of M:s
is certainly an option.

Generally, our MAINTAINERS file is mixing the concepts of who gets CC'ed
for review and who actually applies patches; the block layer makes that
most evident. For qtest we are in need of both aspects.

Regards,
Andreas

[1] http://patchwork.ozlabs.org/patch/318408/
[2] http://patchwork.ozlabs.org/patch/329092/

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg