qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 0/2] qapi: fix coding style in generated code


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v3 0/2] qapi: fix coding style in generated code
Date: Mon, 28 Apr 2014 14:43:30 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Amos Kong <address@hidden> writes:

> Not a serious issue, but it's helpful if we can fix it.
>
> V2: split change of scripts/qapi-visit.py to a split patch,
>     eat space by using a special char as Markus suggested
> V3: update commitlog, update special string, fix of adding
>     const replace string by pattern
>
> Amos Kong (3):
>   qapi: fix coding style in parameters list
>   qapi: add const prefix to 'char *' insider c_type()
>   qapi: Suppress unwanted space between type and identifier
>
>  scripts/qapi-commands.py |  4 +---
>  scripts/qapi-visit.py    | 20 ++++++++++----------
>  scripts/qapi.py          | 20 +++++++++++++-------
>  3 files changed, 24 insertions(+), 20 deletions(-)

Only commit message nitpicks left.  Respin not necessary as far as I'm
concerned.  Thanks!

Reviewed-by: Markus Armbruster <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]