2014-04-28 15:16 GMT+02:00 Andreas Färber <
address@hidden>:
>
> The real question to ask is, does the code have any #ifdef DEBUG_FOO, or
> does the respective maintainer intend to use it that way? If not, then
> your if (DEBUG_FOO) {...} is perfectly valid and makes more sense than
> having ..._ENABLED be anything but a boolean. It's just totally unsafe
> to assume this to work everywhere in one huge cross-maintainer
> refactoring series, as my earlier series showed (which did locate and
> update such #ifdef DEBUG_FOO code). The series becomes non-trivial then.
>
I just checked, and #ifdef is also used in some (not all), so this is not good. Probably the best approach is adding _ENABLED
Marc