[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] QemuOpt: add unit tests
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v3] QemuOpt: add unit tests |
Date: |
Mon, 28 Apr 2014 21:02:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 28.04.2014 20:55, schrieb Leandro Dorileo:
> ping?
>
>
> On Tue, Mar 25, 2014 at 10:27:19AM -0300, Leandro Dorileo wrote:
>> Cover basic aspects and API usage for QemuOpt. The current implementation
>> covers the API's planned to be changed by Chunyan Liu in his
>> QEMUOptionParameter
>> replacement/cleanup job.
>>
>> Other APIs should be covered in future improvements.
>>
>> Signed-off-by: Leandro Dorileo <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> ---
>> tests/Makefile | 3 +
>> tests/test-qemu-opts.c | 455
>> +++++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 458 insertions(+)
>> create mode 100644 tests/test-qemu-opts.c
I don't spot any test API or style issues; not familiar enough with
QemuOpts to judge the tests though.
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg