[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 07/15] hmp: Guard against misuse of hmp_handle_er
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 07/15] hmp: Guard against misuse of hmp_handle_error() |
Date: |
Mon, 28 Apr 2014 22:27:46 +0200 |
Null errp argument makes no sense. Assert it's not null, to make this
explicit, and guard against misuse. All current callers pass non-null
errp.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
hmp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hmp.c b/hmp.c
index eb8ff41..ad31ceb 100644
--- a/hmp.c
+++ b/hmp.c
@@ -28,7 +28,8 @@
static void hmp_handle_error(Monitor *mon, Error **errp)
{
- if (error_is_set(errp)) {
+ assert(errp);
+ if (*errp) {
monitor_printf(mon, "%s\n", error_get_pretty(*errp));
error_free(*errp);
}
--
1.8.1.4
- [Qemu-devel] [PATCH v2 08/15] qapi: Drop redundant, unclean error_is_set(), (continued)
- [Qemu-devel] [PATCH v2 08/15] qapi: Drop redundant, unclean error_is_set(), Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 13/15] qemu-option: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 11/15] qga: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 10/15] qapi: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 15/15] qmp: Don't use error_is_set() to suppress additional errors, Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 12/15] qga: Drop superfluous error_is_set(), Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 07/15] hmp: Guard against misuse of hmp_handle_error(),
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 09/15] tests/qapi-schema: Drop superfluous error_is_set(), Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 14/15] dump: Drop pointless error_is_set(), DumpState member errp, Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 06/15] qga: Use return values instead of error_is_set(errp), Markus Armbruster, 2014/04/28