[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] savevm: check vmsd for migratability status
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH] savevm: check vmsd for migratability status |
Date: |
Mon, 28 Apr 2014 17:36:24 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Apr 25, 2014 at 07:47:09PM -0300, Marcelo Tosatti wrote:
>
> Check vmsd for unmigratable field, allowing migratibility status
> to be modified after vmstate_register.
>
> Signed-off-by: Marcelo Tosatti <address@hidden>
>
> diff --git a/savevm.c b/savevm.c
> index 22123be..61a25c0 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -452,7 +452,7 @@ bool qemu_savevm_state_blocked(Error **errp)
> SaveStateEntry *se;
>
> QTAILQ_FOREACH(se, &savevm_handlers, entry) {
> - if (se->no_migrate) {
> + if (se->no_migrate || (se->vmsd && se->vmsd->unmigratable)) {
The only place where se->no_migrate is set to non-zero is when a vmsd is
provided. What about just removing the field and using
(se->vmsd && se->vmsd->unmigratable) only?
--
Eduardo
- [Qemu-devel] [patch 1/2] target-i386: support "invariant tsc" flag, (continued)
- [Qemu-devel] [patch 1/2] target-i386: support "invariant tsc" flag, Marcelo Tosatti, 2014/04/23
- [Qemu-devel] [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed, Marcelo Tosatti, 2014/04/23
- Re: [Qemu-devel] [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed, Eduardo Habkost, 2014/04/23
- [Qemu-devel] target-i386: block migration and savevm if invariant tsc is exposed (v3), Marcelo Tosatti, 2014/04/23
- Re: [Qemu-devel] target-i386: block migration and savevm if invariant tsc is exposed (v3), Eduardo Habkost, 2014/04/24
- Re: [Qemu-devel] target-i386: block migration and savevm if invariant tsc is exposed (v3), Marcelo Tosatti, 2014/04/25
- Re: [Qemu-devel] target-i386: block migration and savevm if invariant tsc is exposed (v3), Eduardo Habkost, 2014/04/25
- Re: [Qemu-devel] target-i386: block migration and savevm if invariant tsc is exposed (v3), Marcelo Tosatti, 2014/04/25
- [Qemu-devel] [PATCH] savevm: check vmsd for migratability status, Marcelo Tosatti, 2014/04/25
- Re: [Qemu-devel] [PATCH] savevm: check vmsd for migratability status,
Eduardo Habkost <=
- [Qemu-devel] [PATCH] savevm: check vmsd for migratability status (v2), Marcelo Tosatti, 2014/04/29
- Re: [Qemu-devel] [PATCH] savevm: check vmsd for migratability status (v2), Eduardo Habkost, 2014/04/30