qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/5] vscclient: use glib thread primitives not q


From: Michael Tokarev
Subject: Re: [Qemu-devel] [PATCH 3/5] vscclient: use glib thread primitives not qemu
Date: Tue, 29 Apr 2014 12:08:54 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0

29.04.2014 12:03, Christophe Fergeau wrote:
> Hey,
> 
> On Tue, Apr 29, 2014 at 10:02:26AM +0400, Michael Tokarev wrote:
>> Use glib-provided thread primitives in vscclient, not qemu
>> thread primitives.  This way, vscclient becomes more stand-alone.
> 
> For what it's worth, this patch has a few non-threading related bits in
> it because of the removal of #include "qemu/sockets.h" I guess.

Yes indeed, the commit message can be a bit more accurate.
It removes usage of qemu sockets too -- the only socket interface
it needed is socket(AF_INET, SOCK_STREAM), which I used instead of
qemu_socket().  Plus a cal to WSAStartup for a windows platform.
There's no need to use whole libqemuutil.a (which pulls in another
pile of symbols) just for the 2 tiny functions.

I'll mention this in the improved commit message.

Thank you!

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]