qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2] mirror: Fix resource leak when bdrv_getlength fa


From: Fam Zheng
Subject: [Qemu-devel] [PATCH v2] mirror: Fix resource leak when bdrv_getlength fails
Date: Tue, 29 Apr 2014 18:09:09 +0800

The direct return will skip releasing of all the resouces at
immediate_exit, don't miss that.

Signed-off-by: Fam Zheng <address@hidden>

---
v2: Don't call block_job_completed twice. (Kevin)

Signed-off-by: Fam Zheng <address@hidden>
---
 block/mirror.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/mirror.c b/block/mirror.c
index 36f4f8e..2f0361e 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -325,8 +325,8 @@ static void coroutine_fn mirror_run(void *opaque)
 
     s->common.len = bdrv_getlength(bs);
     if (s->common.len <= 0) {
-        block_job_completed(&s->common, s->common.len);
-        return;
+        ret = s->common.len;
+        goto immediate_exit;
     }
 
     length = (bdrv_getlength(bs) + s->granularity - 1) / s->granularity;
-- 
1.9.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]