qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/8] kvm: reset state from the CPU's reset metho


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 1/8] kvm: reset state from the CPU's reset method
Date: Tue, 29 Apr 2014 14:43:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

Il 29/04/2014 14:09, Andreas Färber ha scritto:
Am 29.04.2014 13:54, schrieb Paolo Bonzini:
Now that we have a CPU object with a reset method, it is better to
keep the KVM reset close to the CPU reset.  Using qemu_register_reset
as we do now keeps them far apart.

With this patch, ARM and PPC no longer call the kvm_arch_ function, so
it can get removed there.  i386 and s390x call it from X86CPU/S390CPU
reset handler, and the function gets an X86CPU/S390CPU.

Note that s390-specific functions are called kvm_s390_*, while
x86-specific functions are called kvm_arch_*, so this series only
renames the S390 kvm_arch_reset_vcpu.  Changing that is the topic of a
separate patch.

Reviewed-by: Gleb Natapov <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
 include/sysemu/kvm.h   |  2 --
 kvm-all.c              | 11 -----------
 target-i386/cpu.c      |  5 +++++
 target-i386/kvm.c      |  3 +--
 target-i386/kvm_i386.h |  1 +
 target-ppc/kvm.c       |  4 ----
 target-s390x/cpu.c     |  4 ++++
 target-s390x/cpu.h     |  5 +++++
 target-s390x/kvm.c     |  6 ++++--
 9 files changed, 20 insertions(+), 21 deletions(-)

Contrary to the commit message, the patch does not update target-arm/,
did you check whether it compiles there?

It does on x86, but probably does not on ARM.  /me dusts off the cubietruck.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]