Re: [Qemu-devel] [PATCH v3 00/12] target-i386: Support check/enforce flags & -cpu host in TCG mode, too

[Eduardo Habkost]

On Tue, Apr 29, 2014 at 03:51:17PM +0200, Paolo Bonzini wrote:
> Il 23/04/2014 22:37, Eduardo Habkost ha scritto:
> >On Wed, Apr 23, 2014 at 05:29:28PM -0300, Eduardo Habkost wrote:
> >>This removes some duplication in the CPU feature checking and filtering 
> >>code in
> >>cpu.c, and as a nice side-effect, will make the "check" and "enforce" flags 
> >>work
> >>in TCG mode too.
> >
> >The series description was supposed to mention the 2 new patches, but I
> >forgot to add it, sorry. In addition to the filtering/checking refactor,
> >it includes two new features: the "invtsc" CPU flag, and the support for
> >"-cpu host" in TCG mode.
> >
> >
> >>
> >>Changes v2 -> v3:
> >> * Rebase after QEMU v2.0.0 (onto commit 2d03b49)
> >> * Added new patch: target-i386: support "invariant tsc" flag
> >> * Added new patch: target-i386: Support "-cpu host" in TCG mode
> >>
> >>Changes v1 -> v2:
> >> * Rebase to latest qom-cpu (commit 90c5d39c)
> >>
> >>Cc: Igor Mammedov <address@hidden>
> >>Cc: Andreas Färber <address@hidden>
> >>Cc: Paolo Bonzini <address@hidden>
> >>Cc: Aurelien Jarno <address@hidden>
> >>Cc: Richard Henderson <address@hidden>
> >>Cc: Marcelo Tosatti <address@hidden>
> >>
> >>Eduardo Habkost (11):
> >>  target-i386: Simplify reporting of unavailable features
> >>  target-i386: Merge feature filtering/checking functions
> >>  target-i386: Pass FeatureWord argument to
> >>    report_unavailable_features()
> >>  target-i386: Isolate KVM-specific code on CPU feature filtering logic
> >>  target-i386: Make TCG feature filtering more readable
> >>  target-i386: Filter FEAT_7_0_EBX TCG features too
> >>  target-i386: Filter KVM and 0xC0000001 features on TCG
> >>  target-i386: Define TCG_*_FEATURES earlier on cpu.c
> >>  target-i386: Loop-based feature word filtering in TCG mode
> >>  target-i386: Support check/enforce flags in TCG mode, too
> >>  target-i386: Support "-cpu host" in TCG mode
> >>
> >>Marcelo Tosatti (1):
> >>  target-i386: support "invariant tsc" flag
> >>
> >> target-i386/cpu.c | 274 
> >> +++++++++++++++++++++++++++++++-----------------------
> >> target-i386/cpu.h |   1 +
> >> 2 files changed, 157 insertions(+), 118 deletions(-)
> >>
> >>--
> >>1.9.0
> >>
> >
> 
> I think the agreement in the other thread was to drop patch 11 for
> now until a control for migratability is implemented.  Patch 12
> shouldn't conflict though.

Agreed.

-- 
Eduardo