[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/8] curl: Fix hang reading from slow connection
From: |
Richard W.M. Jones |
Subject: |
Re: [Qemu-devel] [PATCH 0/8] curl: Fix hang reading from slow connections |
Date: |
Tue, 29 Apr 2014 20:01:01 +0100 |
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Tue, Apr 29, 2014 at 04:03:24PM +0100, Matthew Booth wrote:
> [PATCH 1/8] curl: Fix long line
> [PATCH 2/8] curl: Remove unnecessary use of goto
> [PATCH 3/8] curl: Fix return from curl_read_cb with invalid state
> [PATCH 4/8] curl: Remove erroneous sleep waiting for curl completion
> [PATCH 5/8] curl: Remove unnecessary explicit calls to internal event
> [PATCH 6/8] curl: Eliminate unnecessary use of curl_multi_socket_all
> [PATCH 7/8] curl: Ensure all informationals are checked for
> [PATCH 8/8] curl: Fix hang reading from slow connections
>
> Of the following patchset, only patch 8/8 is required to fix the critical
> issue.
> Patches 1 and 2 are trivial cleanups. Patches 3-7 fix various issues with the
> usage of the qemu_aio_* and curl apis which may or may not result in real user
> problems.
I tried the patch series and it works for me (with Fedora curl's which
previously didn't work with qemu). Test command below.
Rich.
$ http_proxy= LIBGUESTFS_BACKEND=direct LIBGUESTFS_HV=~/d/qemu/qemu.wrapper
guestfish -a
http://onuma.home.annexia.org/media/installers/Fedora-19-Cloud-x86_64/Fedora-x86_64-19-20130627-sda.qcow2
--ro -i
Welcome to guestfish, the guest filesystem shell for
editing virtual machine filesystems and disk images.
Type: 'help' for help on commands
'man' to read the manual
'quit' to quit the shell
Operating system: Fedora release 19 (Schrödinger’s Cat)
/dev/sda1 mounted on /
><fs> ll /
total 84
dr-xr-xr-x. 18 root root 4096 Jun 27 2013 .
drwxr-xr-x 19 root root 4096 Apr 29 18:58 ..
lrwxrwxrwx. 1 root root 7 Jun 27 2013 bin -> usr/bin
dr-xr-xr-x. 4 root root 4096 Jun 27 2013 boot
drwxr-xr-x 4 root root 4096 May 11 2013 dev
drwxr-xr-x. 63 root root 4096 Jun 27 2013 etc
drwxr-xr-x. 2 root root 4096 May 11 2013 home
lrwxrwxrwx. 1 root root 7 Jun 27 2013 lib -> usr/lib
lrwxrwxrwx. 1 root root 9 Jun 27 2013 lib64 -> usr/lib64
drwx------. 2 root root 16384 Jun 27 2013 lost+found
drwxr-xr-x. 2 root root 4096 May 11 2013 media
drwxr-xr-x. 2 root root 4096 May 11 2013 mnt
drwxr-xr-x. 2 root root 4096 May 11 2013 opt
drwxrwxr-x 2 root root 4096 Jun 27 2013 proc
dr-xr-x---. 2 root root 4096 Jun 27 2013 root
drwxr-xr-x. 11 root root 4096 Jun 27 2013 run
lrwxrwxrwx. 1 root root 8 Jun 27 2013 sbin -> usr/sbin
drwxr-xr-x. 2 root root 4096 May 11 2013 srv
drwxrwxr-x 2 root root 4096 Jun 27 2013 sys
drwxrwxrwt. 2 root root 4096 Jun 27 2013 tmp
drwxr-xr-x. 13 root root 4096 Jun 27 2013 usr
drwxr-xr-x. 18 root root 4096 Jun 27 2013 var
><fs>
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
- [Qemu-devel] [PATCH 0/8] curl: Fix hang reading from slow connections, Matthew Booth, 2014/04/29
- [Qemu-devel] [PATCH 1/8] curl: Fix long line, Matthew Booth, 2014/04/29
- [Qemu-devel] [PATCH 2/8] curl: Remove unnecessary use of goto, Matthew Booth, 2014/04/29
- [Qemu-devel] [PATCH 5/8] curl: Remove unnecessary explicit calls to internal event handler, Matthew Booth, 2014/04/29
- [Qemu-devel] [PATCH 4/8] curl: Remove erroneous sleep waiting for curl completion, Matthew Booth, 2014/04/29
- [Qemu-devel] [PATCH 7/8] curl: Ensure all informationals are checked for completion, Matthew Booth, 2014/04/29
- [Qemu-devel] [PATCH 3/8] curl: Fix return from curl_read_cb with invalid state, Matthew Booth, 2014/04/29
- [Qemu-devel] [PATCH 6/8] curl: Eliminate unnecessary use of curl_multi_socket_all, Matthew Booth, 2014/04/29
- [Qemu-devel] [PATCH 8/8] curl: Fix hang reading from slow connections, Matthew Booth, 2014/04/29
- Re: [Qemu-devel] [PATCH 0/8] curl: Fix hang reading from slow connections,
Richard W.M. Jones <=
- Re: [Qemu-devel] [PATCH 0/8] curl: Fix hang reading from slow connections, Kevin Wolf, 2014/04/30