[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 14/16] qemu-img: Improve error messages
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL 14/16] qemu-img: Improve error messages |
Date: |
Wed, 30 Apr 2014 08:16:25 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/30/2014 08:12 AM, Mike Day wrote:
> On Sun, Apr 27, 2014 at 9:55 PM, Fam Zheng <address@hidden> wrote:
>>>> /* not found */
>>>> - help();
>>>> - return 0;
>>>> + error_exit("Command not found: %s", cmdname);
>>>
>>> Looks like we just relied previously on the default 'not found' case
>>> for help() to provide the "--help" option.
>>>
>>
>> Oops! Thanks for noticing this and sending the fix.
>
> One of you guys going to send in the trivial patch to restore help?
> (Or is it upstream in another patch?)
Additional patches:
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg04074.html
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg04468.html
both already on the queue for the next PULL request of the block branch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 07/16] curl: Replaced old error handling with error reporting API., (continued)
- [Qemu-devel] [PULL 07/16] curl: Replaced old error handling with error reporting API., Kevin Wolf, 2014/04/23
- [Qemu-devel] [PULL 11/16] qemu-img: Avoid duplicate block device IDs, Kevin Wolf, 2014/04/23
- [Qemu-devel] [PULL 13/16] qemu-iotests: Check common namespace for id and node-name, Kevin Wolf, 2014/04/23
- [Qemu-devel] [PULL 10/16] block: Add errp to bdrv_new(), Kevin Wolf, 2014/04/23
- [Qemu-devel] [PULL 12/16] block: Catch duplicate IDs in bdrv_new(), Kevin Wolf, 2014/04/23
- [Qemu-devel] [PULL 14/16] qemu-img: Improve error messages, Kevin Wolf, 2014/04/23
[Qemu-devel] [PULL 09/16] convert fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create(), Kevin Wolf, 2014/04/23
[Qemu-devel] [PULL 08/16] block: Remove -errno return value from bdrv_assign_node_name, Kevin Wolf, 2014/04/23
[Qemu-devel] [PULL 15/16] vmdk: Fix "%x" to PRIx32 in format strings for cid, Kevin Wolf, 2014/04/23
[Qemu-devel] [PULL 16/16] block/cloop: use PRIu32 format specifier for uint32_t, Kevin Wolf, 2014/04/23
[Qemu-devel] [PULL 06/16] block: Handle error of bdrv_getlength in bdrv_create_dirty_bitmap, Kevin Wolf, 2014/04/23
Re: [Qemu-devel] [PULL 00/16] Block patches, Peter Maydell, 2014/04/25