Re: [Qemu-devel] [PATCH v10 4/4] qapi: Add a primitive to include other files from a QAPI schema file

[Lluís Vilanova]

Eric Blake writes:

> On 04/30/2014 01:09 PM, Lluís Vilanova wrote:
>> The primitive uses JSON syntax, and include paths are relative to the file 
>> using the directive:
>> 
>> { 'include': 'path/to/file.json' }
>> 
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> ---

>> +++ b/tests/qapi-schema/include-after-err.json
>> @@ -0,0 +1,2 @@
>> +{ 'include': 'include-simple-sub.json' }
>> +{ 'command' 'missing-colon' }

> In v9, Markus pointed out that 'include-after-err' is the wrong name for
> this test - you are testing that an error after include is detected
> correctly, and not the behavior of an error after an include.

> It's not a showstopper (I could live with v10 going into the tree), so:

> Reviewed-by: Eric Blake <address@hidden>

> But if you want to spin a v11, then rename the related files and the
> Makefile rules to run the new name.  As a rename is trivially testable
> by 'make check' still passing, then if that's the only change you make,
> I'm still okay if you keep my R-b in your v11 message.

Right, I forgot to comment on this change. I did not want to change the name
because right now all tests start with "include-", which makes it simple to spot
them on a directory list.


Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth