Re: [Qemu-devel] [PATCH 3/3] arm: add EFM32GG-DK3750 support

[Andreas Färber]

Hi,

Am 04.05.2014 17:52, schrieb Rabin Vincent:
> Add support for the EFM32GG990 MCU and its development board
> EFM32GG-DK3750.  This is a Cortex-M3 platform supported
> by mainline Linux.
> 
> Signed-off-by: Rabin Vincent <address@hidden>
> ---
>  default-configs/arm-softmmu.mak |  1 +
>  hw/arm/Makefile.objs            |  1 +
>  hw/arm/efm32.c                  | 71 
> +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 73 insertions(+)
>  create mode 100644 hw/arm/efm32.c

Apart from a missing cover letter to reply to, the preceding two devices
look good to me - this machine however is copying the wrong code. For
one, no semicolon after machine_init() please ;) and more importantly
please follow the example set by Canon A1000 and Allwinner A10 for SoC
vs. machine modeling. Not only does it help clarify what is actually on
the board and what on the chip and facilitates reuse by future EFM32
based boards, it also helps with the technical conversion to QOM realize
and the QOM composition tree.

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg