[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/10] usb: mtp: fix error path memory leak
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 06/10] usb: mtp: fix error path memory leak |
Date: |
Mon, 5 May 2014 13:12:35 +0200 |
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Peter Wu <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
hw/usb/dev-mtp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 775dc8d..45f9562 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -669,6 +669,7 @@ static MTPData *usb_mtp_get_object(MTPState *s, MTPControl
*c,
d->fd = open(o->path, O_RDONLY);
if (d->fd == -1) {
+ usb_mtp_data_free(d);
return NULL;
}
d->length = o->stat.st_size;
@@ -688,6 +689,7 @@ static MTPData *usb_mtp_get_partial_object(MTPState *s,
MTPControl *c,
d->fd = open(o->path, O_RDONLY);
if (d->fd == -1) {
+ usb_mtp_data_free(d);
return NULL;
}
--
1.8.3.1
- [Qemu-devel] [PULL 00/10] usb patch queue, Gerd Hoffmann, 2014/05/05
- [Qemu-devel] [PULL 02/10] usb: mtp: replace debug printfs with trace points, Gerd Hoffmann, 2014/05/05
- [Qemu-devel] [PULL 06/10] usb: mtp: fix error path memory leak,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 01/10] usb-ohci: Add vmstate descriptor, Gerd Hoffmann, 2014/05/05
- [Qemu-devel] [PULL 03/10] usb: mtp: fix usb_mtp_add_u64, Gerd Hoffmann, 2014/05/05
- [Qemu-devel] [PULL 07/10] usb: mtp: avoid empty description string, Gerd Hoffmann, 2014/05/05
- [Qemu-devel] [PULL 09/10] usb: mtp: fix possible buffer overflow, Gerd Hoffmann, 2014/05/05
- [Qemu-devel] [PULL 08/10] usb: mtp: drop data-out hexdump, Gerd Hoffmann, 2014/05/05
- [Qemu-devel] [PULL 04/10] usb: mtp: fix version (is decimal not bcd), Gerd Hoffmann, 2014/05/05
- [Qemu-devel] [PULL 10/10] usb: mtp: reply INCOMPLETE_TRANSFER on read errors, Gerd Hoffmann, 2014/05/05
- [Qemu-devel] [PULL 05/10] usb: mtp: fix serial (must be exact 32 chars), Gerd Hoffmann, 2014/05/05
- Re: [Qemu-devel] [PULL 00/10] usb patch queue, Peter Maydell, 2014/05/07