[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] glib: add compat wrapper for GStaticMutex
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] glib: add compat wrapper for GStaticMutex |
|
Date: |
Mon, 5 May 2014 14:11:15 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, May 02, 2014 at 03:08:07PM +0400, Michael Tokarev wrote:
> Stefan Hajnoczi:
>
> > Avoid duplicating ifdefs for the deprecated GStaticMutex API by
> > introducing compat_g_static_mutex_*() in glib-compat.h.
> >
> > GStaticMutex users should use the compat API to avoid dealing with
> > deprecation.
>
> To my taste this is a wrong(ish) approach.
The different approaches to hiding gthread API deprecation have their
pros/cons but mostly a question of taste. If you want to merge your
patch I'm fine with that.
Stefan