Re: [Qemu-devel] [PATCH] iotests: Use configured python

[Peter Maydell]

On 5 May 2014 13:26, Stefan Hajnoczi <address@hidden> wrote:
> On Sat, May 03, 2014 at 04:47:08PM +0200, Max Reitz wrote:
>> @@ -56,22 +57,22 @@ for IMGOPTS in "compat=0.10" "compat=1.1"; do
>>      echo === Create image with unknown header extension ===
>>      echo
>>      _make_test_img 64M
>> -    ./qcow2.py "$TEST_IMG" add-header-ext 0x12345678 "This is a test header 
>> extension"
>> -    ./qcow2.py "$TEST_IMG" dump-header
>> +    $PYTHON qcow2.py "$TEST_IMG" add-header-ext 0x12345678 "This is a test 
>> header extension"
>> +    $PYTHON qcow2.py "$TEST_IMG" dump-header
>
> Please use "$PYTHON" to humor the people who like to put spaces in their
> path names.

Won't that cause problems if configure sets $PYTHON to "python -B" ?

>> @@ -215,9 +222,16 @@ do
>>
>>          start=`_wallclock`
>>          $timestamp && echo -n "        ["`date "+%T"`"]"
>> -        [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
>> +
>> +        if [ "$(head -n 1 $seq)" == "#!/usr/bin/env python" ]; then
>> +            run_command="$PYTHON $seq"
>
> The code generally uses the older `` notation instead of $().  Please
> use ``.

$() is nicer though...

thanks
-- PMM