Re: [Qemu-devel] [v5 PATCH 0/2] apic: bump emulated lapic version to 0x14

[Andreas Färber]

Am 05.05.2014 17:51, schrieb Michael S. Tsirkin:
> On Mon, May 05, 2014 at 10:52:49AM -0400, Gabriel L. Somlo wrote:
>> On Mon, May 05, 2014 at 01:42:00PM +0200, Alexander Graf wrote:
>>> From what I understand about the compat bits (which is little) this
>>> makes a lot of sense. And the version is a proper property now,
>>> which is great :).
>>>
>>> Acked-by: Alexander Graf <address@hidden>
>>
>> Thanks! Here's a new version with only 8 bits dedicated to the
>> "implementation version", as specified in the documentation for
>> the "apic version register".
>>
>> Cheers,
>>   Gabriel
> 
> 
> Acked-by: Michael S. Tsirkin <address@hidden>
> 
> I'll pick this up unless there are objections.

Objection! .compat_props are being added to the current pc and q35
machines rather than introducing pc-i440fx-2.1 and pc-q35-2.1 machines
and adding the compat_props for the 2.0 versions only.

If 2.1 machines without .compat_props get added and the alias is moved
from 2.0 to 2.1, it'll be fine.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg