qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] i8259: don't abort when trying to use level sen


From: Hervé Poussineau
Subject: Re: [Qemu-devel] [PATCH] i8259: don't abort when trying to use level sensitive irqs
Date: Mon, 05 May 2014 22:02:55 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0

Le lun. 05 mai 2014 10:01:10 CEST, Michael S. Tsirkin a écrit :
On Sat, May 03, 2014 at 10:39:37PM +0200, Hervé Poussineau wrote:
Ping.

Le 22/04/2014 23:00, Hervé Poussineau a écrit :
This is a guest-triggerable error, as seen when using Xenix 2.3.4.
Replace hw_error by LOG_UNIMPL, so that guests have at least a chance to 
continue.

Signed-off-by: Hervé Poussineau <address@hidden>

Is it just "a chance" or does Xenix actually work well with this
applied?

Yes,
With this patch, I can install and use Xenix 2.3.4a without any problem.
I can also start installation of Xenix 2.3.4q, but it fails due to not finding an hard disk.

Regards,

Hervé



---
  hw/intc/i8259.c |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
index c6f248b..a069d04 100644
--- a/hw/intc/i8259.c
+++ b/hw/intc/i8259.c
@@ -265,7 +265,8 @@ static void pic_ioport_write(void *opaque, hwaddr addr64,
              s->init4 = val & 1;
              s->single_mode = val & 2;
              if (val & 0x08) {
-                hw_error("level sensitive irq not supported");
+                qemu_log_mask(LOG_UNIMP,
+                              "i8259: level sensitive irq not supported\n");
              }
          } else if (val & 0x08) {
              if (val & 0x04) {







reply via email to

[Prev in Thread] Current Thread [Next in Thread]