Re: [Qemu-devel] [PATCH 06/13] qapi: Clean up shadowing of parameters and locals in inner scopes

[Eric Blake]

On 05/02/2014 06:44 AM, Markus Armbruster wrote:
> By un-inlining the visit of nested complex types.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi-visit.py | 20 +++++++++++++++++---
>  1 file changed, 17 insertions(+), 3 deletions(-)
> 

> @@ -106,8 +122,6 @@ if (!error_is_set(errp)) {
>  
>      if len(field_prefix):
>          ret += mcgen('''
> -Error **errp = &err; /* from outer scope */
> -Error *err = NULL;

Eww.  Yeah, that's worth cleaning up.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature