[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/13] qapi-visit.py: Clean up a sloppy use of f
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/13] qapi-visit.py: Clean up a sloppy use of field prefix |
|
Date: |
Mon, 05 May 2014 14:44:40 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/02/2014 06:44 AM, Markus Armbruster wrote:
> generate_visit_struct_fields() generates the base type's struct member
> name both with and without the field prefix. Harmless, because the
> field prefix is always empty there: only unboxed complex members have
> a prefix, and those can't have a base type.
>
> Clean it up anyway.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi-visit.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 02/13] qapi: Normalize marshalling's visitor initialization and cleanup, (continued)
- [Qemu-devel] [PATCH 02/13] qapi: Normalize marshalling's visitor initialization and cleanup, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 05/13] qapi-visit.py: Clean up confusing push_indent() / pop_indent() use, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 12/13] qapi: Replace uncommon use of the error API by the common one, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 06/13] qapi: Clean up shadowing of parameters and locals in inner scopes, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 07/13] qapi-visit.py: Clean up a sloppy use of field prefix, Markus Armbruster, 2014/05/02
- Re: [Qemu-devel] [PATCH 07/13] qapi-visit.py: Clean up a sloppy use of field prefix,
Eric Blake <=
- [Qemu-devel] [PATCH 13/13] error: error_is_set() is finally unused; remove, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 11/13] tests: Don't call visit_end_struct() after visit_start_struct() fails, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 10/13] hw: Don't call visit_end_struct() after visit_start_struct() fails, Markus Armbruster, 2014/05/02