Re: [Qemu-devel] [PATCH 10/13] hw: Don't call visit_end_struct() after visit_start_struct() fails

[Eric Blake]

On 05/02/2014 06:44 AM, Markus Armbruster wrote:
> When visit_start_struct() succeeds, visit_end_struct() must not be

s/succeeds/fails/ (this really confused me on my first read, until I saw
the code and the subject line and determined the typo)

> called.  rtc_get_date() and balloon_stats_all() call it anyway.  As
> far as I can tell, they're only used with the string output visitor,
> which doesn't care.  Fix them anyway.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  hw/timer/mc146818rtc.c     | 23 +++++++++++++++--------
>  hw/virtio/virtio-balloon.c | 25 +++++++++++++++++++------
>  2 files changed, 34 insertions(+), 14 deletions(-)

With commit message fixed,

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature