Re: [Qemu-devel] [PATCH v12 4/4] qapi: Add a primitive to include other files from a QAPI schema file

[Lluís Vilanova]

Luiz Capitulino writes:

> On Fri,  2 May 2014 15:52:41 +0200
> Lluís Vilanova <address@hidden> wrote:

>> --- a/scripts/qapi.py
>> +++ b/scripts/qapi.py
>> @@ -11,6 +11,8 @@
>> # This work is licensed under the terms of the GNU GPL, version 2.
>> # See the COPYING file in the top-level directory.
>> 
>> +import os
>> +import re
>> from ordereddict import OrderedDict
>> import os
>> import sys
>> @@ -36,9 +38,17 @@ builtin_type_qtypes = {
>> 'uint64':   'QTYPE_QINT',
>> }

> You're importing os twice in this series. I saw this while applying an
> unrelated patch on top. I'll drop the import added by this patch, please
> reply ACKing or NACKing.

Ok.

Sorry for the silly mistake.

Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth