Re: [Qemu-devel] [PATCH V26 20/32] qed.c: replace QEMUOptionParameter with QemuOpts

[Stefan Hajnoczi]

On Tue, Apr 29, 2014 at 05:10:44PM +0800, Chunyan Liu wrote:
> One extra change is to define QED_DEFAULT_CLUSTER_SIZE = 65536 instead
> of 64 * 1024; because:
> according to existing create_options, "cluster size" has default value =
> QED_DEFAULT_CLUSTER_SIZE, after switching to create_opts, this has to be
> stringized and set to .def_value_str. That is,
>   .def_value_str = stringify(QED_DEFAULT_CLUSTER_SIZE),
> so the QED_DEFAULT_CLUSTER_SIZE could not be a expression.
> 
> Signed-off-by: Dong Xu Wang <address@hidden>
> Signed-off-by: Chunyan Liu <address@hidden>
> ---
>  block/qed.c | 114 
> ++++++++++++++++++++++++++++++++----------------------------
>  block/qed.h |   3 +-
>  2 files changed, 61 insertions(+), 56 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>