Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

[Benoît Canet]

The Tuesday 06 May 2014 à 09:27:25 (-0400), Luiz Capitulino wrote :
> On Tue, 6 May 2014 15:07:40 +0200
> Benoît Canet <address@hidden> wrote:
> 
> > I am trying to use this series to modularise the block API.
> > 
> > Here are my finding.
> > 
> > I tried to make a qmp/block.json including VM state related API.
> > block.json include a qmp/block-core.json containing only true block stuff.
> > 
> > When generating and compiling block-core.json to link it with qemu-nbd
> > I saw that some of the block stuff needed ErrorClass so I went the route
> > of creating a qmp/common.json containing ErrorClass.
> > 
> > common.json being included in block-core.json and in qapi-schema.json it
> > quickly lead some code being generated in double and the compilation to 
> > choke.
> > 
> > What do you think would be the best solution to fix this ?
> > (Fix the generator ? Make include ignore second inclusion of the same file 
> > ?)
> 
> Make qapi-schema.json a sort of master file and include everything?

My problem is that I need something smaller than qapi-schema.json to link 
against
qemu-nbd.

> 
> Eventually, we might want to have if/defs and whatnot. But having a master
> file seems a reasonable first step to me. I actually thought this was the
> intention. Unless I got it wrong, of course.
>