[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] glib: fix g_poll early timeout on windows
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH v3] glib: fix g_poll early timeout on windows |
Date: |
Tue, 06 May 2014 18:52:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
Am 06.05.2014 17:49, schrieb Alex Bligh:
>
> On 6 May 2014, at 13:38, Paolo Bonzini wrote:
>
>> Il 06/05/2014 14:23, Stefan Hajnoczi ha scritto:
>>>>> Signed-off-by: Stanislav Vorobiov <address@hidden>
>>>>> ---
>>>>> include/glib-compat.h | 19 +++++++++
>>>>> include/qemu-common.h | 12 ------
>>>>> util/oslib-win32.c | 112
>>>>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>>>> 3 files changed, 131 insertions(+), 12 deletions(-)
>>> What is the status of this patch?
>>>
>>> I haven't followed the discussions around the issue but can review/merge
>>> if there is agreement now.
>>
>> The GNOME folks haven't followed up, so I think we should pick it.
>
> I haven't checked it on win32 but was happy with it otherwise.
There was another patch on the list which moved g_poll code from
qemu-common.h to glib-compat.h, so when both patches get merged I expect
a (trivial) merge conflict.
The patch looks good. I already have applied it to my local queue, but I
won't be able to test it before end of next week. If someone wants to
pick it up earlier, I would not mind.
Cheers,
Stefan