Re: [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux version

[Peter Maydell]

On 6 May 2014 19:16, Mike Day <address@hidden> wrote:
> This updates scripts/checkpatch.pl to version 0.32. Also,
> forward-ported the QEMU checks for no tabs and correct capitalization
> of "QEMU." Finally, make --no-tree the default option since this will
> be used with Qemu.
>
> Signed-off-by: Mike Day <address@hidden>
> ---
>
> Notes: This is a huge patch and I needed to include white space
> changes to get it applying cleanly.
> I've tested this so far with some random patches off the mailing list
> and some others that I've got around. I also tested for some intentional
> errors.
>
>  scripts/checkpatch.pl | 2544 
> ++++++++++++++++++++++++++++++++++++++++---------
>  1 file changed, 2120 insertions(+), 424 deletions(-)

I think this is going to be difficult to review, to say the least.

Where does your patch come from? Is the kernel's checkpatch.pl
just a single commit between 0.31 and 0.32 (surely not) or
a series of fixes?

A couple of ideas about how we could approach this:
 (1) make a commit which is simply copying the kernel's 0.32
      into our repo; then follow that with a series of commits which
      re-apply our local changes.
 (2) apply all the individual commits from the kernel between 0.31
     and 0.32 to our repo
 (3) give up and stick with 0.31...

(note that 1 and 2 here both end up with the same result as
applying this patch, but with a different commit history to get
there.)

We only have 16 commits which touch checkpatch.pl, so
my favourite of these is (1). This also makes it easier when
we want to upgrade to 0.33 some time in the future, I think.

It might also be helpful if you could describe the benefits
we get from this update (any bugfixes for false positives we
tend to run into? useful new checks?)

thanks
-- PMM