Re: [Qemu-devel] [PATCH v3 00/14] qmp qga: Purge error_is_set()

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> On Fri,  2 May 2014 13:26:28 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> I got a private branch getting rid of it entirely.  This is the fifth
>> part, covering QMP and the guest agent up to the point where I start
>> messing with the QAPI code generators.  That's left for the final
>> part.
>> 
>> Luiz agreed to take this through his tree.
>> 
>> This series conflicts with Lluís's "qapi: Allow modularization of QAPI
>> schema files", but only in docs/writing-qmp-commands.txt, and
>> resolution is trivial.
>
> I didn't get any conflicts.

Even better :)

> Have you looked at Laszlo series to make sure it follows your guidelines?
>
>  http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg01506.html

Looks fine to me at a glance: no new error_is_set(), all Error * and
Error ** variables are nicely named.

> I've already applied his series to my tree, btw. Yours is on top.
>
> Applied to the qmp branch, thanks.

Thanks!