Re: [Qemu-devel] [PATCH 2/3] PPC: Allow little-endian user mode.

[關振德]

On Thu, May 8, 2014 at 2:11 AM, Alexander Graf <address@hidden> wrote:

On 05/08/2014 11:05 AM, Doug Kwan (關振德) wrote:

There are a few places where we do 128-bit loads/store.  We need to swap the high/low halves and also do byteswap for each half.  Byteswap of each half is handled differently depending on TARGET_WORDS_BIGENDIAN but the swapping of high/low halves is always controlled by msr.le.  Would our intention be clearer if defined another function swap_high_low_64_bits() instead of msr.le?

This is my last warning about top posting. One more top post and I will ignore any future email from you.

The explanation makes a lot of sense. This probably just deserves a quick comment in the code so that nobody stumbles over this when he looks at it :).


Alex

I'm terribly sorry about the mail format.  I did not realize what "top-posting" was until I do a quick search just now. It does not help that Gmail does top-posting by default.  I just noticed that I may have missed the multi-word load store.  I will write a small test case tomorrow morning to check that they are okay.

Thanks

-Doug