[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 17/25] block/raw-win32: implement .bdrv_detac
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 17/25] block/raw-win32: implement .bdrv_detach/attach_aio_context() |
|
Date: |
Thu, 8 May 2014 13:25:32 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, May 07, 2014 at 12:35:40PM +0200, Paolo Bonzini wrote:
> >@@ -207,7 +217,6 @@ out_free_state:
> >
> > void win32_aio_cleanup(QEMUWin32AIOState *aio)
> > {
> >- qemu_aio_set_event_notifier(&aio->e, NULL);
>
> Perhaps it would be safer not to leave a dangling pointer in the
> AioContext, and detach manually here (or at least add an assertion).
> Can be done as a follow-up though.
I will add the assertion.
- Re: [Qemu-devel] [PATCH v2 13/25] quorum: implement .bdrv_detach/attach_aio_context(), (continued)
- [Qemu-devel] [PATCH v2 15/25] block/linux-aio: fix memory and fd leak, Stefan Hajnoczi, 2014/05/07
- [Qemu-devel] [PATCH v2 16/25] block/raw-win32: create one QEMUWin32AIOState per BDRVRawState, Stefan Hajnoczi, 2014/05/07
- [Qemu-devel] [PATCH v2 11/25] nfs: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/07
- [Qemu-devel] [PATCH v2 18/25] rbd: use BlockDriverState's AioContext, Stefan Hajnoczi, 2014/05/07
- [Qemu-devel] [PATCH v2 17/25] block/raw-win32: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/07
- [Qemu-devel] [PATCH v2 20/25] ssh: use BlockDriverState's AioContext, Stefan Hajnoczi, 2014/05/07
- [Qemu-devel] [PATCH v2 21/25] vmdk: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/07
- [Qemu-devel] [PATCH v2 22/25] dataplane: use the QEMU block layer for I/O, Stefan Hajnoczi, 2014/05/07
- [Qemu-devel] [PATCH v2 23/25] dataplane: delete IOQueue since it is no longer used, Stefan Hajnoczi, 2014/05/07
- [Qemu-devel] [PATCH v2 24/25] dataplane: implement async flush, Stefan Hajnoczi, 2014/05/07
- [Qemu-devel] [PATCH v2 25/25] raw-posix: drop raw_get_aio_fd() since it is no longer used, Stefan Hajnoczi, 2014/05/07
- [Qemu-devel] [PATCH v2 19/25] sheepdog: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/07