[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [
|
From: |
Gonglei (Arei) |
|
Subject: |
Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?] |
|
Date: |
Fri, 9 May 2014 10:59:01 +0000 |
> -----Original Message-----
> From: Gerd Hoffmann [mailto:address@hidden
> Sent: Friday, May 09, 2014 6:55 PM
> To: Gonglei (Arei)
> Cc: address@hidden; address@hidden; address@hidden;
> address@hidden; Huangweidong (C); Blue Swirl
> Subject: Re: [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch
> false positive?]
>
> Hi,
>
> > BTW, what's your opinion about isa cirrus vga device, Gerd?
>
> I'd do the same check there.
>
But isa_cirrus_vga_realizefn() has no return value for judgment.
Adding the isa init function back?
Best regards,
-Gonglei
Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size, Dr. David Alan Gilbert, 2014/05/09
Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size, Paolo Bonzini, 2014/05/09
Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size, Eric Blake, 2014/05/12