Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

[Andreas Färber]

Am 09.05.2014 12:59, schrieb Gonglei (Arei):
>> -----Original Message-----
>> From: Gerd Hoffmann [mailto:address@hidden
>> Sent: Friday, May 09, 2014 6:55 PM
>> To: Gonglei (Arei)
>> Cc: address@hidden; address@hidden; address@hidden;
>> address@hidden; Huangweidong (C); Blue Swirl
>> Subject: Re: [PATCH] cirrus_vga: adding sanity check for vram size 
>> [checkpatch
>> false positive?]
>>
>>   Hi,
>>
>>> BTW, what's your opinion about isa cirrus vga device, Gerd?
>>
>> I'd do the same check there.
>>
> But isa_cirrus_vga_realizefn() has no return value for judgment.
> Adding the isa init function back?

No, realizefn is the replacement for the old initfns. Adding qtests for
verifying that things still work is what's holding up the conversion of
PCI devices.

You need to set *errp via error_setg(errp, "..."); instead of
error_report() and then just return.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg