[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] hw/intc/allwinner-a10-pic: Add missing 'bre
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] hw/intc/allwinner-a10-pic: Add missing 'break' |
Date: |
Sat, 10 May 2014 08:45:52 +1000 |
On Fri, May 9, 2014 at 4:46 AM, Peter Maydell <address@hidden> wrote:
> Add missing 'break' after handling of AW_A10_PIC_BASE_ADDR write.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
> ---
> hw/intc/allwinner-a10-pic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/intc/allwinner-a10-pic.c b/hw/intc/allwinner-a10-pic.c
> index 0924d98..7b3e085 100644
> --- a/hw/intc/allwinner-a10-pic.c
> +++ b/hw/intc/allwinner-a10-pic.c
> @@ -97,6 +97,7 @@ static void aw_a10_pic_write(void *opaque, hwaddr offset,
> uint64_t value,
> switch (offset) {
> case AW_A10_PIC_BASE_ADDR:
> s->base_addr = value & ~0x3;
> + break;
> case AW_A10_PIC_PROTECT:
> s->protect = value;
> break;
> --
> 1.9.2
>
>
- [Qemu-devel] [PATCH 0/8] misc fixes for coverity warnings in ARM devices, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH 7/8] hw/arm/stellaris: Correct handling of GPTM TAR register, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH 8/8] hw/arm/omap_gpmc: Avoid buffer overrun filling prefetch FIFO, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH 4/8] hw/arm/omap1: Avoid unintended sign extension writing omap_rtc YEARS_REG, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH 1/8] hw/intc/allwinner-a10-pic: Add missing 'break', Peter Maydell, 2014/05/08
- Re: [Qemu-devel] [PATCH 1/8] hw/intc/allwinner-a10-pic: Add missing 'break',
Peter Crosthwaite <=
- [Qemu-devel] [PATCH 2/8] hw/net/cadence_gem: Remove dead code, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH 3/8] hw/display/pxa2xx_lcd: Fix 16bpp+alpha and 18bpp+alpha palette formats, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH 6/8] hw/timer/exynos4210_mct: Avoid overflow in exynos4210_ltick_recalc_count, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH 5/8] hw/dma/omap_dma: Add (uint32_t) casts when shifting uint16_t by 16, Peter Maydell, 2014/05/08